Re: [coreboot] v2[PATCH]RCA RM4100 i82830 support

> > +static void do_ram_command(const struct mem_controller *ctrl,   
> > uint32_t command, uint32_t addr_offset)
> > +{
> >
> > <snip>
> > +
> > +	/* Read from (DIMM start address + addr_offset). */
> > +	read32(0 + addr_offset);	//first offset is always 0
> > +}
>
> This isn't ready for multiple dimms yet. See the cn700 patch I   
> recently sent (but haven't committed yet, I think it was acked).

Oh you mean this? What do I need to do to adapt it for the i82830?

+	/* NOTE: Dual-sided ready */
    read32(0 + addr_offset);
+	for(i = 0; i < (ARRAY_SIZE(ctrl->channel0) * 2); i++) {
+		reg8 = pci_read_config8(ctrl->d0f3, 0x40 + i);
+		if(reg8) read32((reg8 << 26) + addr_offset);
+	}

Thanks - Joe