Re: [coreboot] [PATCH] Maximum/default console log level for kconfig

[Stefan Reinauer]

On Oct 16, 2009, at 20:36, "Myles Watson"  wrote:
> > On Mon, Oct 12, 2009 at 4:17 PM, Uwe Hermann   
> > wrote:
> > > On Mon, Oct 12, 2009 at 02:09:03PM -0600, Myles Watson wrote:
> > > > > > > +config MAXIMUM_CONSOLE_LOGLEVEL_8
> > > > > > > +        bool "8: BIOS_SPEW"
> > > >
> > > > BIOS_SPEW is 9, not 8.  Could you fix it?
> > >
> > > Hm, nope, I think all Config.lb files are wrong here, they should  
> > > use 8.
> > > #define BIOS_DEBUG      7   /* debug-level  
> > > messages                 */
> > > #define BIOS_SPEW       8   /* Way too many  
> > > details                 */
> > >
> > > Using 9 has the same effect as using 8 I guess.
> >
> > Nope.  Spew messages don't show up anymore.
>
> ...
> > While I was fooling with it, I made Kconfig ensure that
> > MAXIMUM_CONSOLE_LOGLEVEL >= DEFAULT_CONSOLE_LOGLEVEL to minimize the
> > number of test cases I needed.
> >
> > Signed-off-by: Myles Watson
>
> Ping.
>
> I'd like to be able to say "Try Kconfig with SPEW", but it doesn’t w 
> ork.

Acked-by: Stefan Reinauer
> Thanks,
> Myles