Re: [coreboot] [PATCH] Proposal for dealing with superio *.c includes

[Alex G.]

On 03/03/2011 09:35 AM, Georgi, Patrick wrote:
> The chipset components in Kconfig could be derived from the
> devicetree.cb (statically, on config time or before) - this would
> simplify board config a bit by reducing duplication.
>
> Early serial could be managed with a new keyword there
> ("chip superio/foo/bar early")
>
> Thoughts?

I like the idea. It's long term, and cleaner.

chip superio/foo/bar		# Super I/O
              device pnp 2e.1 on		# Com1
                io 0x60 = 0x3f8
                irq 0x70 = 4
                serial_console
              end

So not only would we specify that the superio hosts the serial console,
but also at which address that is, eliminating the need for
#define SERIAL_DEV PNP_DEV(0x2e, FOOBAR_SP1)
in romstage.c

+1

Alex