Re: [coreboot] [PATCH 3/5] libpayload: Implement ffs()

[Stefan Reinauer]

* Patrick Georgi  [110225 13:11]:
> Signed-off-by: Patrick Georgi
>
> payloads/libpayload/include/strings.h |   35 ++++++++++++++++++++++++++++
>  payloads/libpayload/libc/Makefile.inc |    2 +-
>  payloads/libpayload/libc/strings.c    |   40 +++++++++++++++++++++++++++++++++
>  3 files changed, 76 insertions(+), 1 deletions(-)
>  create mode 100644 payloads/libpayload/include/strings.h
>  create mode 100644 payloads/libpayload/libc/strings.c
>
> diff --git a/payloads/libpayload/include/strings.h b/payloads/libpayload/include/strings.h
> new file mode 100644
> index 0000000..ce7fe93
> --- /dev/null
> +++ b/payloads/libpayload/include/strings.h
> @@ -0,0 +1,35 @@
> +#ifndef _STRING_H
> +#define _STRING_H

This should be _STRINGS_H otherwise it can/will conflict.

Otherwise

Acked-by: Stefan Reinauer