On Wed, May 02, 2007 at 09:53:45AM -0700, ron minnich wrote:
SystemPreInit();[...]
pll_reset(ManualConf);cpuRegInit();Those names may be the fault of Ollie or me, not sure; Marc, change if you wish.
So, I'm with Peter, I'd go for the Acked-by: Ronald G. Minnich rminnich@gmail.com and, Marc, consider either a new patch with Uwe's recommendations or fixup later. But I don't want to delay getting this in; there are some customers waiting for it, literally daily.
I agree, let's commit ASAP and fix the smaller issues later in extra patches.
However, the following things should be fixed before we commit, IMHO:
- All license issues.
- The commit should not break other targets, apart from OLPC maybe. At the moment a few more targets will be broken (see my other mail).
Also, I think we should commit all four patches in one go, otherwise I'm almost certain that the build will be broken...
Uwe.