Re: [coreboot] [commit] r6247 - trunk/src/mainboard/nokia/ip530

[Stefan Reinauer]

This is not particularly beautiful. Is there any advantage of using the
irq hack rather than putting this as code into some mainboard specific
init function?
> @@ -40,10 +40,55 @@
>      device pnp 3f0.8 on		# AUX I/O
>        irq 0x24 = 0x84		# OSC
>        irq 0xB2 = 0x0C		# Soft power status 1
>        irq 0xB3 = 0x05		# Soft power status 2
>        irq 0xC0 = 0x03		# IRQ MUX control
>        irq 0xC8 = 0x10		# GP50 = (I/O) output = Flashrom enable
>        irq 0xCA = 0x09		# GP52 = IRQ8 (output)
>        irq 0xCB = 0x01		# GP53 = nROMCS (output)

------ 8< -------
>        irq 0xCC = 0x11		# GP54 = (I/O) input

------ >8 -------
>        irq 0xF9 = 0x00             # read/write GP5x lines (0x1C)
>        irq 0xD0 = 0x08		# GP60 = IRQ1
>        irq 0xD1 = 0x08		# GP61 = IRQ3
>        irq 0xD2 = 0x08		# GP62 = IRQ4

------ 8< -------
>        irq 0xD3 = 0x11		# GP63 = (I/O) input = JP901 on board
>        irq 0xD4 = 0x11		# GP64 = (I/O) input
>        irq 0xD5 = 0x11		# GP65 = (I/O) input

------ >8 -------

I don't think writing to GP inputs makes a lot of sense. Guess this
could/should be dropped.
>        irq 0xD6 = 0x08		# GP66 = IRQ8

------ 8< -------
>        irq 0xD7 = 0x11		# GP67 = (I/O) input

------ >8 -------
>        irq 0xFA = 0x00		# read/write GP6x lines (0x88)
>        irq 0xE0 = 0x00		# GP10 (I/O) = output

------ 8< -------
>        irq 0xE1 = 0x01		# GP11 (I/O) = input

------ >8 -------
>        irq 0xE2 = 0x08		# GP12 = P17
>        irq 0xE3 = 0x00		# GP13 (I/O) = output = LED fault on front, active low
>        irq 0xE4 = 0x00		# GP14 (I/O) = output
>        irq 0xE5 = 0x00		# GP15 (I/O) = output

------ 8< -------
>        irq 0xE6 = 0x01		# GP16 (I/O) = input = JP900 on board, low on short, high on open

------ >8 -------
>        irq 0xE7 = 0x00 		# GP17 (I/O) = output = LED alert on front, active low
>        irq 0xF6 = 0xFF		# read/write GP1x lines (0xCA)
>        irq 0xEF = 0x00		# GP_INT2 disable
>        irq 0xF0 = 0x00		# GP_INT1 disable
>        irq 0xF1 = 0x00		# WDT_UNITS
>        irq 0xF2 = 0x00		# WDT_VAL
>        irq 0xF3 = 0x00		# WDT_CFG
>        irq 0xF4 = 0x20		# WDT_CTRL (stop-cnt)
>      end
>      device pnp 3f0.a off 		# ACPI (No support yet)
>        # irq 0x60 = 0x0C
>        # irq 0x61 = 0x80
>      end
>    end
>  end
>  device pci 7.1 on end		# IDE

Stefan