On Mon, Oct 4, 2021 at 8:12 PM Julian Stecklina julian.stecklina@cyberus-technology.de wrote:
The X86_GOOD_APIC was set in the past in a few configs. You can find them via:
git log -S GOOD_APIC --source --all
The define itself was finally removed in:
commit fc57d6c4c2848726be1361f6dee3c33e7551b857 Author: Patrick Rudolph siro@das-labor.org Date: Tue Nov 12 16:30:14 2019 +0100
cpu/x86/lapic: Support x86_64 and clean up code
From then on all APICs were "bad".
But it looks like the workaround was just carried forward with no discussion of whether it's still necessary or what it actually works around.
Hi
Removal has been suggested with the X2APIC work:
https://review.coreboot.org/c/coreboot/+/55199
Regards, Kyösti