Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
2 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s)
** CID 1431154: Control flow issues (DEADCODE) /src/ec/kontron/kempld/kempld_i2c.c: 254 in kempld_i2c_device_init()
________________________________________________________________________________________________________ *** CID 1431154: Control flow issues (DEADCODE) /src/ec/kontron/kempld/kempld_i2c.c: 254 in kempld_i2c_device_init() 248 if (spec_major == 1) 249 prescale = KEMPLD_CLK / (KEMPLD_I2C_FREQ_STD * 5) - 1000; 250 else 251 prescale = KEMPLD_CLK / (KEMPLD_I2C_FREQ_STD * 4) - 3000; 252 253 if (prescale < 0)
CID 1431154: Control flow issues (DEADCODE) Execution cannot reach this statement: "prescale = 0L;".
254 prescale = 0; 255 256 /* Round to the best matching value */ 257 prescale_corr = prescale / 1000; 258 if (prescale % 1000 >= 500) 259 prescale_corr++;
** CID 1353302: (OVERRUN) /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 74 in keyboard_raw_drive_column() /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 71 in keyboard_raw_drive_column() /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 66 in keyboard_raw_drive_column() /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 83 in keyboard_raw_drive_column()
________________________________________________________________________________________________________ *** CID 1353302: (OVERRUN) /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 74 in keyboard_raw_drive_column() 68 69 if (out == KEYBOARD_COLUMN_ALL) { 70 /* drive low (clear bit) */ 71 bsrr |= gpio_list[j].mask << 16; 72 } else if (out == KEYBOARD_COLUMN_NONE) { 73 /* put output in hi-Z state (set bit) */
CID 1353302: (OVERRUN) Overrunning array "gpio_list" of 41 16-byte elements at element index 47 (byte offset 767) using index "j" (which evaluates to 47).
74 bsrr |= gpio_list[j].mask; 75 } else if (j - GPIO_KB_OUT00 == out) { 76 /* 77 * Drive specified output low, others => hi-Z. 78 * 79 * To avoid conflict, tri-state all outputs /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 71 in keyboard_raw_drive_column() 65 for (j = GPIO_KB_OUT00; j <= GPIO_KB_OUT12; j++) { 66 if (gpio_list[j].port != kb_out_ports[i]) 67 continue; 68 69 if (out == KEYBOARD_COLUMN_ALL) { 70 /* drive low (clear bit) */
CID 1353302: (OVERRUN) Overrunning array "gpio_list" of 41 16-byte elements at element index 47 (byte offset 767) using index "j" (which evaluates to 47).
71 bsrr |= gpio_list[j].mask << 16; 72 } else if (out == KEYBOARD_COLUMN_NONE) { 73 /* put output in hi-Z state (set bit) */ 74 bsrr |= gpio_list[j].mask; 75 } else if (j - GPIO_KB_OUT00 == out) { 76 /* /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 66 in keyboard_raw_drive_column() 60 61 for (i = 0; i < ARRAY_SIZE(kb_out_ports); i++) { 62 uint32_t bsrr = 0; 63 int j; 64 65 for (j = GPIO_KB_OUT00; j <= GPIO_KB_OUT12; j++) {
CID 1353302: (OVERRUN) Overrunning array "gpio_list" of 41 16-byte elements at element index 47 (byte offset 767) using index "j" (which evaluates to 47).
66 if (gpio_list[j].port != kb_out_ports[i]) 67 continue; 68 69 if (out == KEYBOARD_COLUMN_ALL) { 70 /* drive low (clear bit) */ 71 bsrr |= gpio_list[j].mask << 16; /3rdparty/chromeec/chip/stm32/keyboard_raw.c: 83 in keyboard_raw_drive_column() 77 * Drive specified output low, others => hi-Z. 78 * 79 * To avoid conflict, tri-state all outputs 80 * first, then assert specified output. 81 */ 82 keyboard_raw_drive_column(KEYBOARD_COLUMN_NONE);
CID 1353302: (OVERRUN) Overrunning array "gpio_list" of 41 16-byte elements at element index 47 (byte offset 767) using index "j" (which evaluates to 47).
83 bsrr |= gpio_list[j].mask << 16; 84 done = 1; 85 break; 86 } 87 } 88
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...