On Wed, Nov 21, 2007 at 10:43:09AM -0700, Myles Watson wrote:
How about this fix? Can you test the attached patch? It fixes it in uclibc.mk instead of in each individual board.
Very good, that works for me and it's more elegant.
If the patch works for you, I'll send a full patch from the latest svn.
Excellent.
The problem is that the amount that is free in the ROM is dependent on the size of the ROM, the size of LinuxBIOS, and any other payloads you have in your configuration. Thus checkrom depends on a magic number to say if it will fail or not.
Choose a platform with a ROM_SIZE smaller than 1 MB and checkrom doesn't protect you from linker errors. Choose to use a 2 MB ROM and checkrom fails even when it shouldn't.
Ok, that makes sense. Is there a way to export ROM_SIZE and access it from the check_rom script? That way this check would always make sense.
If that's easy it would be great to add it now; otherwise we should probably leave it for a future patch.
Acked-by: Ward Vandewege ward@gnu.org
Thanks, Ward.