Re: [coreboot] r3818 build service

[Myles Watson]

On Thu, Dec 18, 2008 at 5:16 PM, Marc Jones  wrote:
> On Thu, Dec 18, 2008 at 12:10 PM, Myles Watson  wrote:
> > On Thu, Dec 18, 2008 at 11:42 AM, coreboot information <
>
> [e-mail]>
> > wrote:
> > > Dear coreboot readers!
> > >
> > > This is the automated build check service of coreboot.
> > >
> > > The developer "myles" checked in revision 3818 to
> > > the coreboot source repository and caused the following
> > > changes:
> > >
> > > Change Log:
> > > This patch gets rid of all the implicit definition warnings for
>
> serengeti
> > > except get_nodes.
> > >
> > > Signed-off-by: Myles Watson 
> > > Acked-by: Marc Jones
> > >
> > > Build Log:
> > > Compilation of asus:m2v-mx_se has been broken
> > > See the error log at
>
> http://qa.coreboot.org/log_buildbrd.php?revision=3818&device=m2v-mx_se&a...
> > Should this board have HAVE_HARD_RESET 1?  That fixes the build.  If not,
> > I'm not sure how to fix the macro definition of hard_reset in
> > src/include/part/hard_reset.h.  It seems strange to hang without a
>
> message,
> > but that's not what's causing the build failure.
>
> Yes, I think that is the problem. It has a hard reset function in
> cache_as_ram_auto.c but the function is empty. Remove the function and
> leave the macro?

Then the build is still broken.  The empty function says that the board
should have a hard_reset, but it's not implemented.  I think the right thing
to do is define HAVE_HARD_RESET and add a #warning that it isn't
implemented.  Thoughts?

Thanks,
Myles