Re: [LinuxBIOS] EPIA-M status

[Jonathan McDowell]

On Tue, Jun 07, 2005 at 09:08:22AM -0600, Josiah England wrote:
> Attached is the diffs file generated by 'tla changes --diffs'.

Great, thanks. Minor issue I found while using it as a basis for the
EPIA-M stuff:
> +static void ide_init(struct device *dev)
> +{
> +	struct southbridge_via_vt8231_config *conf;
> +	unsigned char enables;
> +
> +	if (!conf->enable_native_ide) {

I think you want:

	struct southbridge_via_vt8231_config *conf = dev->chip_info;

otherwise you're dereferencing an uninitialised pointer?

J.

-- 
           101 things you can't have too much of : 3 - Sleep.
      Ask me about server co-location - [e-mail]