* Peter Stuge peter@stuge.se [080513 21:35]:
On Tue, May 13, 2008 at 07:06:01PM +0200, Stefan Reinauer wrote:
So I joined my utility collection and made one bigger tool out of it: inteltool
Great idea.
case 0x27b8: // ICH7 gpiobase = pci_read_word(sb, 0x48) & 0xfffc; break; case 0x1234: // Dummy for non-existent functionality printf("Error: This southbridge does not have GPIOBASE.\n"); return 1;
Maybe device ID #defines would be nice?
done.
/* Determine names */ switch(nb->device_id) { case 0x27a0: nbname="i945"; break; default: nbname="unknown"; }
switch(sb->device_id) { case 0x27b8: sbname="ICH7"; break; default: sbname="unknown"; }
I'd prefer to have a table for this, maybe the same one that has register definitions?
done.
It's not in the register definitions though. If you have an idea how to do this nicely, I suggest we integrate this in other patches. Also, we might want to see how other intel chipsets come in over time to see what is beneficial and what is not.
No ack from me yet, but next time, Gadget!
Ok, 'nother try:
Signed-off-by: Stefan Reinauer stepan@coresystems.de
This time only inteltool.c is attached, the rest staid unchanged.