Good day! Starting with commit 0a4457ff44b10f22b711f64e88888c757fbedf32 which introduced a disabled-by-default CONFIG_CBMEM_STAGE_CACHE option - https://github.com/coreboot/coreboot/commit/0a4457ff44b10f22b711f64e88888c75... - S3 resume freezes on G505S if this option isn't enabled.
Commit message tells that "AGESA platforms without TSEG will experience slower S3 resume speed unless they explicitly select the option.", however I've waited for like an hour but it's still stuck and can't be turned on later without a force shutdown and full laptop discharge.
Here is a diff for S3 resume log obtained with USB FT232H dongles, left side - before this commit, right side - after it but with this option disabled - http://www.mergely.com/MOfZeDPX/ . Where the left side had "usbdebug: ramstage starting... S3 Resume.", right side gave a sudden restart of romstage initialization and soon got stuck after APIC 00: ** Enter AmdInitEarly [00020002]. Force shutdown without a full discharge gave "RAM INIT FAILURE" after "APIC 00: ** Exit AmdInitResume [00020008]" soon after that, and only a full discharge helps to get this laptop working again.
There's the same behavior for a fresh coreboot as well. Here is my coreboot config I've used as a base - https://pastebin.com/6Nj6e6xZ . Is this problem expected? If not, I could help by testing your debug builds aimed on fixing it.
In addition, S3 resume is also not working with CONFIG_SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT even if CONFIG_CBMEM_STAGE_CACHE is enabled.
Maybe we should introduce a Kconfig "switch" for G505S CONFIG_HAVE_ACPI_RESUME option at ./src/mainboard/lenovo/g505s/Kconfig ? A new option CONFIG_ACPI_RESUME , which could be enabled only with CONFIG_CBMEM_STAGE_CACHE and without CONFIG_SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT
Best regards, Mike Banon