ron minnich wrote:
On Jan 21, 2008 10:12 AM, Marc Jones <marc.jones@amd.com> wrote:
Patches appreciated. Hints: - artecgroup/dbe61 first failed in r527 with "undefined reference to 'spd_read_byte'" - adl/msm800sev and amd/norwich first failed in r537 with "conflicting types for 'spd_read_byte'", which was uncovered by the new combined compilation, but the root cause (conflicting types) had been there for dozens of revisions.
This is probably mostly my fault, I will try to fix.
Here is what I had done to get norwich building. Marc -- Marc Jones Senior Firmware Engineer (970) 226-9684 Office mailto:Marc.Jones@amd.com http://www.amd.com/embeddedprocessors Signed-off-by: Marc Jones <marc.jones@amd.com> Index: LinuxBIOSv3/southbridge/amd/cs5536/smbus_initram.c =================================================================== --- LinuxBIOSv3.orig/southbridge/amd/cs5536/smbus_initram.c 2008-01-11 15:35:37.000000000 -0700 +++ LinuxBIOSv3/southbridge/amd/cs5536/smbus_initram.c 2008-01-11 15:57:06.000000000 -0700 @@ -343,7 +343,7 @@ * @param address The address. * @return The data from the SMBus packet area or an error of 0xff (i.e. -1). */ -int spd_read_byte(u16 device, u8 address) +u8 spd_read_byte(u16 device, u8 address) { return smbus_read_byte(device, address); } Signed-off-by: Marc Jones <marc.jones@amd.com> Index: LinuxBIOSv3/include/lib.h =================================================================== --- LinuxBIOSv3.orig/include/lib.h 2008-01-11 15:52:52.000000000 -0700 +++ LinuxBIOSv3/include/lib.h 2008-01-11 16:04:12.000000000 -0700 @@ -36,11 +36,4 @@ void beep_short(void); void beep_long(void); -/* smbus functions */ -int smbus_read_byte(unsigned device, unsigned address); - -/* dram functions */ -void ram_failure(const char *why); -void ram_initialize(int controllers, void *ctrl); - #endif /* LIB_H */