On Mon, Jan 21, 2008 at 04:01:57PM -0700, Marc Jones wrote:
-/* smbus functions */ -int smbus_read_byte(unsigned device, unsigned address);
hmm. So where does the prototype live then?
There's include/device/smbus.h with int smbus_read_byte(struct device *dev, u8 addr); and also include/lib.h with int smbus_read_byte(unsigned device, unsigned address); at the moment.
The latter should be dropped IMO, include/device/smbus.h sounds like the correct place to have the prototype.
-/* dram functions */ -void ram_failure(const char *why); -void ram_initialize(int controllers, void *ctrl);
These are in lib/ram.c and even defined in the documentation ;-)
What should we do about that?
You have a point. There should be a standard prototype but lib.h seemed to be a random place for them.
I think that's ok, IIRC we did this in order to not have yet another almost-empty header file (ram.h). We should try to keep the number of files (especially useless *.h files) down as much as possible/reasonable.
Uwe.