Re: [coreboot] Patch: Update Geode LX code to avoid FILO/Kernel problems

[Stefan Reinauer]

Hi Edwin,

I know it's a while back but it looks like this patch is not really
doing what it says because c0000 - fffff were ram_resource'd before,
too. Just with a separate call. Did this not work? I think we do this in
many places.

Stefan

On 1/27/10 6:17 PM, Edwin Beasant wrote:
> This patch adds e- and f-segment as an available RAM area on the AMD
> lx-northbridge platforms and fixes FILO compatibility
>      Allows SeaBios to become resident correctly
>
>      Prevents Linux kernel resource problems when booted with
>
> FILO and VGA MSR's written
>      Allows use of the Geode VGA patches
>
>
>
> Signed-off-by: Edwin Beasant
> Index: src/northbridge/amd/lx/northbridge.c
>
> --- src/northbridge/amd/lx/northbridge.c        (revision 5057)
> +++ src/northbridge/amd/lx/northbridge.c        (working copy)
> @@ -414,8 +414,8 @@
>                 /* Report the memory regions */
>                 idx = 10;
>                 ram_resource(dev, idx++, 0, 640);
>           ram_resource(dev, idx++, 768, 1024); // c0000-fffff
>
> are usable
>           ram_resource(dev, idx++, 1024, tomk - 1024);    //
>
> Systop - 1 MB -> KB
>           //ram_resource(dev, idx++, 768, 1024); // c0000-fffff
>
> are usable
>           ram_resource(dev, idx++, 768, tomk - 768);      //
>
> Systop - 1 MB -> KB
>
> #if CONFIG_WRITE_HIGH_TABLES==1
>                 /* Leave some space for ACPI, PIRQ and MP tables */