29. November 2023 12:14, "Poeche, Uwe via coreboot" coreboot@coreboot.org schrieb:
Your above mentioned patch helps (I'm a reviewer of this). When I tried I also noticed that this does not point out loudly if you have problems in your config. So the approach without the patch (in result more strict) is from my opinion better if we have a workaround beside edit config manually. In the parallel thread here Martin mentioned the same workaround as you mentioned on IRC on Monday. But I get not work.
Right, because the code checks for the variables' presence, not for their value. I was mistaken on that, as was Martin apparently.
I modified the changeset so that it still doesn't fail on warnings during *config, but still prints them. That doesn't matter a whole lot with menuconfig and nconfig because they proceed to clear the screen immediately after, but oldconfig and olddefconfig are somewhat more helpful now:
$ make oldconfig /home/pgeorgi/coreboot/.config:152:warning: unknown symbol: VBT_DATA_SIZE_KB * * Restart config... * ...
$ make olddefconfig /home/pgeorgi/coreboot/.config:152:warning: unknown symbol: VBT_DATA_SIZE_KB # # configuration written to /home/pgeorgi/coreboot/.config #
Does that help?
Patrick