Re: [coreboot] [commit] r5268 - in trunk/src:cpu/amd/car cpu/amd/model_gx2 cpu/amd/sc520mainboard/amd/dbm690t mainboard/amd/mahoganymainboard/amd/mahogany_fam10 mainboard/amd/pistachiomainboard/amd/serengeti_...

[Myles Watson]

> repository service wrote:
> > +++ trunk/src/cpu/amd/car/post_cache_as_ram.c	Mon Mar 22 17:33:25

2010
> (r5268)
> > @@ -97,7 +97,7 @@
> >    /* clear only coreboot used region of memory. Note: this may break
>
> ECC enabled boards */
> > memset((void*) CONFIG_RAMBASE, 0, (CONFIG_RAMTOP) - CONFIG_RAMBASE -
>
> CONFIG_DCACHE_RAM_SIZE);
> > #else
> > memset((void*)0, 0, ((CONFIG_RAMTOP) - CONFIG_DCACHE_RAM_SIZE));
> > //memset((void*)CONFIG_RAMBASE, 0, ((CONFIG_RAMTOP) -
>
> CONFIG_DCACHE_RAM_SIZE - 0xa0000));
> > #endif
> >    print_debug("Done\r\n");
>
> Is this OK?

No.  I reverted it in the next commit.  I was trying to see why fam10 boots
so slowly, and this and another hunk slipped in.
> > +++ trunk/src/mainboard/supermicro/h8dmr/romstage.c	Mon Mar 22 17:33:25
>
> 2010	(r5268)
> > @@ -203,7 +203,7 @@
> >    /* Halt if there was a built in self test failure */
> >    report_bist_failure(bist);
> >    print_debug("*sysinfo range: ["); print_debug_hex32(sysinfo);
>
> print_debug(",");  print_debug_hex32((unsigned long)sysinfo+sizeof(struct
> sys_info)); print_debug(")\r\n");
> > printk(BIOS_DEBUG, "*sysinfo range: [%p,%p]\n",sysinfo,sysinfo+1);
>
> This and another place or two seems to have strange whitespace?

I'll look.  There were a couple of places where indenting was broken in the
original file.
> > +++ trunk/src/mainboard/technologic/ts5300/mainboard.c	Mon Mar 22
>
> 17:33:25 2010	(r5268)
> > @@ -7,7 +7,8 @@
> >  #include "chip.h"
> >
> > -static void irqdump()
> > +#if 0
> > +static void irqdump(void)
>
> Maybe remove the function, or move it to lib/ ?

I didn't because the function call was commented out in the same file.  It
seemed like debugging documentation.

Thanks,
Myles