On Thu, Mar 28, 2019 at 10:16:42PM +0100, Nico Huber wrote:
On 16.03.19 14:50, Nico Huber wrote:
And also a `util/lint/check-style` that is only hooked up if you run `make git-config` recently (I didn't, so I'm a little surprised). This one doesn't have a scope file, it seems?
Does nobody know this one? It seems like a campaign *against* clang- format because it currently blocks anyone with a new clone/gitconfig from committing without reformatting entire files.
e.g., if I do:
$ cd /tmp $ git clone https://review.coreboot.org/coreboot.git $ cd coreboot $ make gitconfig $ echo '/* foo */' >>util/superiotool/ite.c $ git add -u $ git commit -s -m bar
I get to scroll up nearly 1.5k lines to see this:
The following differences were found between the code to commit andthe clang-format rules:
And the style enforced by *this currently active hook* sometimes doesn't comply with our rules and don't pass checkpatch.
I started sending in some patches to coreboot over the past two weeks and have bumped into this. I wasn't sure what to do with it (nobody wants massive file reformats for a simple change), so I've had to run `git commit --no-verify` once to skip the check and write the commit message, and then `git commit --amend` to run the rest of the pre-commit hooks (like adding change id). I'm still not sure what the proper thing to do is.
Jacob Garber