Re: [LinuxBIOS] MSI ms9185 linuxbios support

[ron minnich]

I'm willing to help resolve those failed patches. I agreed to help MSI with
this, so I will probably try to work on this tomorrow. I do want to
understand the ramifications of these
two patches:
> Index: src/southbridge/broadcom/bcm5785/bcm5785_sata.c
> Index: src/devices/emulator/biosemu.c

before I commit them. I think that yhlu understands the broadcom and can
comment on that, and Ollie and I can take a look at the biosemu change.

It is really wonderful to have MSI involved in LinuxBIOS!

We saw an MSI laptop at the LinuxBIOS summit and I for one really liked it.
I wonder if we could look at an MSI laptop that is Turion-based for
LinuxBIOS? I know that the Free Software Foundation would be very happy to
see such a thing.

thanks!

ron

On 10/26/06, Uwe Hermann  wrote:
> Hi,
>
> thanks a lot for you patch! It's great to see an MSI board supported!
>
> A few questions / remarks:
>
> What is the status of the code? Is the mainboard fully supported
>  (with all devices etc), or is this work in progress?
>
> Who owns the copyright to the code? You personally, or MSI?
>  Please add the usual GPL header to all files, see here
>  http://www.linuxbios.org/Development_Guidelines#Common_License_Header
>  for an example.
>  For existing files which you copied and modified the orginal authors
>  and license must also remain in the file, of course.
>
> The patch doesn't seem to apply (anymore?):
>
> patching file src/southbridge/broadcom/bcm5785/bcm5785_sata.c
> Hunk #1 FAILED at 21.
> Hunk #2 FAILED at 32.
> 2 out of 2 hunks FAILED -- saving rejects to file
> src/southbridge/broadcom/bcm5785/bcm5785_sata.c.rej
> patching file src/devices/emulator/biosemu.c
> Hunk #1 FAILED at 121.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/devices/emulator/biosemu.c.rej
> > Index: src/southbridge/broadcom/bcm5785/bcm5785_sata.c
> > Index: src/devices/emulator/biosemu.c
>
> Are the changes to these two files generic, i.e. will they work for all
> other mainboards LinuxBIOS supports, too? Or are they specific to
> this board?
> > Property changes on: src/mainboard/msi/ms9185/Config.lb
> > ___________________________________________________________________
> > Name: svn:executable
>
> If I read this correctly you mark all files executable, which they
> probably should not be. I think these lines can be safely removed
> from the patch.
> > Index: src/mainboard/msi/ms9185/mainboard.c
>
> [...]
> > +#if CONFIG_CHIP_NAME == 1
> > +struct chip_operations mainboard_msi_ms9185_ops = {
> >   CHIP_NAME("MSI ms9185 mainboard")
>
> I would make this read
>   CHIP_NAME("MSI MS-9185 mainboard")
> if my patch from
> http://www.linuxbios.org/pipermail/linuxbios/2006-October/016449.html
> get committed.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
>
> iD8DBQFFQZmEXdVoV3jWIbQRAlz5AJ4iiGIdIYJ8EsVZno0MV86jAIo/2gCdG92v
> vULBtfWcUL2y2gKPA3IVzPk=
> =+6sE
> -----END PGP SIGNATURE-----