On Sun, 2007-04-22 at 03:02 +0200, Uwe Hermann wrote:
Your patch is missing a sign-off, thus cannot be committed.
http://linuxbios.org/Development_Guidelines#Sign-off_Procedure
I updated my patch to use jedec* functions everywhere, please ack.
On Fri, Apr 20, 2007 at 02:26:06PM -0700, roger wrote:
diff -uN ./flashrom/README ./flashrom.mine/README --- ./flashrom/README 2007-04-09 15:59:22.000000000 -0700 +++ ./flashrom.mine/README 2007-04-20 14:03:52.000000000 -0700
Try 'svn diff', that's a lot easier :)
- {"M29F040B", ST_ID, ST_M29F040B, NULL, 512, 64 * 1024,
probe_29f040b, erase_29f040b, write_29f040b, NULL},I've changed this one to use the jedec* functions, too. Untested, of course, but if the others work then this one probably does, too.
I've just noticed a small, appropriately described as trivial, bug.
There is no jedec_erase function. The correct function to call is jedec_chip_erase.
This initially also gave me a spin with the naming consistancy of this function compared to other jedec_* calls (ie. probe_jedec & write_jedec).
With this bug, Atmel AT29C020 chips are not detected.
I will practice using SVN tonight and submit a more official patch.
-- Roger http://www.eskimo.com/~roger/index.html Key fingerprint = 8977 A252 2623 F567 70CD 1261 640F C963 1005 1D61
Wed Apr 25 17:17:23 PDT 2007