On Fri, Mar 27, 2009 at 01:11:08PM +0100, Mondrian Nuessle wrote:
Hi,
as someone already pointed out, we need to enable flashing first on the board using a GPIO pin. I have attached a patch for flashrom that enables flashing on the HP DL145 G3. I tested it on the DL145 I have here.
Please specify the board on the commandline, like in # ./flashrom -m "hp:dl145_g3" -E
The patch is probably not ready for primetime, maybe someone can review it?
Regards, Mondrian
Dr. Mondrian Nuessle Phone: +49 621 181 2717 University of Heidelberg Fax: +49 621 181 2713 Computer Architecture Group mailto:nuessle@uni-hd.de http://ra.ziti.uni-heidelberg.de
Index: flashrom/board_enable.c
--- flashrom/board_enable.c (revision 4027) +++ flashrom/board_enable.c (working copy) @@ -633,6 +633,19 @@ int (*enable) (const char *name); };
+static int board_hp_dl145_g3_enable(const char *name) +{
- uint8_t b;
- outb(0x44, 0x0cd6);
- b = inb(0x0cd7) | 0x24;
- outb(b, 0x0cd7);
- return 0;
+}
struct board_pciid_enable board_pciid_enables[] = { { .first_vendor = 0x1106, @@ -1014,6 +1027,20 @@ .enable = ich6_gpio19_raise, }, {
.first_vendor = 0x1166,.first_device = 0x0205,.first_card_vendor = 0x0000,.first_card_device = 0x0000,.second_vendor = 0x1166,.second_device = 0x0234,.second_card_vendor = 0x0000,.second_card_device = 0x0000,.lb_vendor = "hp",.lb_part = "dl145_g3",.name = "HP DL145 G3",.enable = board_hp_dl145_g3_enable,- },
- { .first_vendor = 0, .first_device = 0, .first_card_vendor = 0,
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Are there no subsystem/board ids available?
And man, does that struct stuff still suck. For a 10 line function, a horrible 14 lines get added to what is basically a table. Cute.
Luc Verhaegen.