Re: [coreboot] [PATCH] flashrom: ST M25P40 bug?

[Peter Stuge]

On Sun, May 11, 2008 at 03:32:46PM +0200, Carl-Daniel Hailfinger wrote:
> Signed-off-by: Carl-Daniel Hailfinger

Needs a commit message of course.
> {"ST",		"M25P40",		ST_ID,		ST_M25P40,		512,	256,		TEST_UNTESTED,	probe_spi,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},
> {"ST",		"M25P40",		ST_ID,		ST_M25P40,		512,	256,		TEST_UNTESTED,	probe_spi_rdid,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},
> {"ST",		"M25P40(old)",		ST_ID,		ST_M25P40_RES,		512,	256,		TEST_UNTESTED,	probe_spi_res,		spi_chip_erase_c7,	spi_chip_write, spi_chip_read},

Hmm. probe_spi_res() calls spi_rdid() first. I don't like duplicating
chips? If multiple checks are needed for one chip I think they should
be in code?

//Peter