Re: [coreboot] buildrom compiler settings patch

[Jordan Crouse]

On 28/05/08 11:00 -0600, Myles Watson wrote:
> This is a simple patch which consolidates the compiler settings.  I think it
> might be better somewhere else, but at least it is consolidated.
>
> Signed-off-by: Myles Watson

Acked-by: Jordan Crouse
> I'm also interested in why we don't set LD at the same time.  Is it an
> oversight?

Probably - we might not have needed LD until this point.
> I'd like to remove the compiler settings in Build.settings and error
> out if there isn't a CC defined by then.  Maybe CONFIG_CC, CONFIG_LD,
> CONFIG_AS, etc. settings in the Build Settings menu of Kconfig makes
> sense.

I like that!
> Thanks,
> Myles
> Index: config/platforms/tyan-s2881.conf
>
> --- config/platforms/tyan-s2881.conf	(revision 198)
> +++ config/platforms/tyan-s2881.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/tyan-s2882.conf
> ===================================================================
> --- config/platforms/tyan-s2882.conf	(revision 198)
> +++ config/platforms/tyan-s2882.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/tyan-s2891.conf
> ===================================================================
> --- config/platforms/tyan-s2891.conf	(revision 198)
> +++ config/platforms/tyan-s2891.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/tyan-s2892.conf
> ===================================================================
> --- config/platforms/tyan-s2892.conf	(revision 198)
> +++ config/platforms/tyan-s2892.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/dbe61.conf
> ===================================================================
> --- config/platforms/dbe61.conf	(revision 198)
> +++ config/platforms/dbe61.conf	(working copy)
> @@ -4,10 +4,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
> Index: config/platforms/msm800sev.conf
>
> --- config/platforms/msm800sev.conf	(revision 198)
> +++ config/platforms/msm800sev.conf	(working copy)
> @@ -3,10 +3,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
> Index: config/platforms/ga-2761gxdk.conf
>
> --- config/platforms/ga-2761gxdk.conf	(revision 198)
> +++ config/platforms/ga-2761gxdk.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT),y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/asus_a8v-e_se.conf
> ===================================================================
> --- config/platforms/asus_a8v-e_se.conf	(revision 198)
> +++ config/platforms/asus_a8v-e_se.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT),y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/tyan-s2895.conf
> ===================================================================
> --- config/platforms/tyan-s2895.conf	(revision 198)
> +++ config/platforms/tyan-s2895.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/alix2c3.conf
> ===================================================================
> --- config/platforms/alix2c3.conf	(revision 198)
> +++ config/platforms/alix2c3.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
> Index: config/platforms/serengeti_cheetah.conf
>
> --- config/platforms/serengeti_cheetah.conf	(revision 198)
> +++ config/platforms/serengeti_cheetah.conf	(working copy)
> @@ -3,10 +3,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT),y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/platforms.conf
> ===================================================================
> --- config/platforms/platforms.conf	(revision 198)
> +++ config/platforms/platforms.conf	(working copy)
> @@ -1,6 +1,11 @@
>  # This will include the correct configuration for the
>  # selected platform
>
> +# Compiler
> +CC=gcc
> +STRIP=strip
> +AS=as
>
> ##Include the correct platform configuration
>
> PLATFORM-y=
> Index: config/platforms/qemu.conf
> ===================================================================
> --- config/platforms/qemu.conf	(revision 198)
> +++ config/platforms/qemu.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i686
>  CFLAGS_platform =
> Index: config/platforms/supermicro-h8dmr.conf
>
> --- config/platforms/supermicro-h8dmr.conf	(revision 198)
> +++ config/platforms/supermicro-h8dmr.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT), y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/norwich.conf
> ===================================================================
> --- config/platforms/norwich.conf	(revision 198)
> +++ config/platforms/norwich.conf	(working copy)
> @@ -3,10 +3,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
> Index: config/platforms/db800.conf
>
> --- config/platforms/db800.conf	(revision 198)
> +++ config/platforms/db800.conf	(working copy)
> @@ -3,10 +3,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
> Index: config/platforms/m57sli.conf
>
> --- config/platforms/m57sli.conf	(revision 198)
> +++ config/platforms/m57sli.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> ifeq ($(CONFIG_TARGET_64BIT),y)
>  TARGET_ARCH=x86_64
>  CFLAGS_platform =
> Index: config/platforms/alix1c.conf
> ===================================================================
> --- config/platforms/alix1c.conf	(revision 198)
> +++ config/platforms/alix1c.conf	(working copy)
> @@ -2,10 +2,6 @@
>
> #### Platform configuration
>
> -CC=gcc
> -STRIP=strip
> -AS=as
>
> TARGET_ARCH=i586
>  CFLAGS_platform =
>