On Tue, May 01, 2007 at 04:48:29PM -0600, Marc Jones wrote:
This patch adds support for the AMD Norwich development platform based on the Geode LX processor. The Norwich is the canonical Geode reference, and will server as a good basis for other Geode based platforms.
So is this a physically existing product or merely a development board/prototype? I'm asking because I'd like to know into which category this should go later in the wiki:
http://linuxbios.org/Supported_Motherboards
Index: LinuxBIOSv2/src/mainboard/amd/norwich/auto.c
--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ LinuxBIOSv2/src/mainboard/amd/norwich/auto.c 2007-05-01 01:32:02.000000000 -0600
[...]
+#define POST_CODE(x) outb(x, 0x80)
Why this? We have a post_code() function in src/console/console.c.
+static void mb_gpio_init(void) +{
- /* Early mainboard specific GPIO setup */
+}
Required, now or later? Otherwise please drop it.
- SystemPreInit();
[...]
- pll_reset(ManualConf);
- cpuRegInit();
Please use lowercase names (and underscores) only for function names, variables etc. I think we have exceptions from this rule in the current code, but in general we try to follow the Linux kernel coding style and conventions:
http://lxr.linux.no/source/Documentation/CodingStyle
+struct chip_operations mainboard_amd_norwich_ops = {
- CHIP_NAME("Norwich mainboard ")
Just some cosmetics: "AMD Norwich Mainboard"
Uwe.