Luc,
OK. I'll need to patch vt823x_gpio_set as it doesn't currently support GPIO < 12.
Jon
-----Original Message----- From: Luc Verhaegen [mailto:libv@skynet.be] Sent: 17 June 2009 23:41 To: Harrison, Jon (SELEX GALILEO, UK) Cc: coreboot@coreboot.org Subject: Re: [coreboot] Flashrom support for EPIA-N(L) - patch for review
Please use vt823x_set_all_writes_to_lpc and vt823x_gpio_set
I will verify and fix gpio_set for setting other gpio lines than 12-15, in the next hour or so.
Remove the //printf.
- {0x1106, 0x0259, 0x1106, 0xaa08, 0x1106, 0x3227, 0x1106,
0xAA08, "via", "epia-n", "VIA", "EPIA-N/NL", board_via_epia_n},
Please remove the coreboot ids. This hardware can be autodetected, and you should not disable rom access in your upcoming coreboot support, and
therefor will not need this board enable.
So NACK on this first pass, but will ack once issues are addressed, and once vt823x_gpio_set is fixed.
Luc Verhaegen.
SELEX Sensors and Airborne Systems Limited Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14 3EL A company registered in England & Wales. Company no. 02426132 ******************************************************************** This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. ********************************************************************