Re: [coreboot] r1057 - in coreboot-v3/arch/x86: . intel/core2

[Carl-Daniel Hailfinger]

On 26.11.2008 02:43, Stefan Reinauer wrote:
> [e-mail] wrote:
> > Author: hailfinger
> > Date: 2008-11-26 00:39:31 +0100 (Wed, 26 Nov 2008)
> > New Revision: 1057
> >
> > Modified:
> >    coreboot-v3/arch/x86/intel/core2/stage0.S
> >    coreboot-v3/arch/x86/stage1.c
> > Log:
> > The Core2Duo CAR code did set up the stack incorrectly. In combination
> > with a wrong calling convention of stage1_phase1() this caused stage1 to
> > assume BIST had failed.
> >
> > Signed-off-by: Carl-Daniel Hailfinger 
> > Acked-by: Ronald G. Minnich
>
> Can you please back this out again? With this code nothing seems to work
> anymore.

I kept the added comments and the two initial pushl $0. Committed in r1058.

If it still fails with svn HEAD, feel free to revert the additional
pushl $0. If the code does fail after that, the breakage was introduced
before my commit (or gcc/gas are malfunctioning).

Regards,
Carl-Daniel