On 06/05/08 15:17 -0600, Myles Watson wrote:
-----Original Message----- From: Jordan Crouse [mailto:jordan.crouse@amd.com] Sent: Tuesday, May 06, 2008 3:05 PM To: Myles Watson Cc: coreboot@coreboot.org Subject: Re: Outstanding patches
On 06/05/08 14:59 -0600, Myles Watson wrote:
On Tue, May 6, 2008 at 2:49 PM, Myles Watson mylesgw@gmail.com wrote:
I have a number of outstanding patches that need to be ACKed or NAKed. Please review if you have the time:
coreinfo submenu patch: http://www.coreboot.org/pipermail/coreboot/2008-April/033837.html coreinfo: Add "a submenu"
Here's a start for this one.
I forgot to say that if you configure it without a couple of menus, it refuses to build because of unused variable warnings. I'm not sure that -Werror is the right thing to do when it's in buildrom, even though I don't like warnings.
Unused functions are bad though - can you point me to the config you used?
I blew it away to test the lar patch...
I will try to recreate it, but it was a rdtsc function that wasn't being used, if that helps.
Ah, yes - somebody else talked about that too. I'll fix that. Thanks.
Jordan