Re: [coreboot] [PATCH] put coreboot table in high tables area

[Kevin O'Connor]

Hi Stefan,

On Mon, Mar 16, 2009 at 05:23:35PM +0100, Stefan Reinauer wrote:
> See patches
>
> I'll gladly send another fix for libpayload if the two patches are accepted

[...]
> --- src/include/boot/coreboot_tables.h	(revision 1304)
> +++ src/include/boot/coreboot_tables.h	(working copy)
> @@ -155,6 +155,13 @@
>    uint16_t type;
>  };
>
> +#define LB_TAG_FORWARD		0x0011
> +struct lb_forward {
> uint32_t tag;
> uint32_t size;
> uint64_t forward;
>
> +};

One suggestion - instead of making the "floating table" be a sub-table
of a coreboot-table, make it a stand alone data structure.  As it
stands, I think existing code might get confused when it finds a
coreboot table without any real data in it.

-Kevin