On Thu, May 03, 2007 at 08:11:43PM +0200, Mondrian Nuessle wrote:
Ok, I looked over everything again. I was blind!
I acked your code, and i didn't really bother to look what you actually were doing. The old register accesses don't invite one to look over them. You were no blinder than i was.
Luc, you are absolutely right. And we do not need a dk8_htx enable function. Just use the ARUMA one.
Smashing. New patch deletes your function, slightly alters the aruma one and renames it to w83627hf_gpio24_raise.
The code I posted was based on reverse engineering registers, it worked for us very well for months. So I never bothered checking the other boards. Sorry.
I tested using the Aruma function on real hw and it works as expected.
After your patch, everything is A LOT better readable.
Yeah. I wouldn't have a single hair on my head left if i hadn't done this very early on for vga io in my unichrome driver :)
Sorry for the hassle, Mondrian
Don't apologise. You saw this through to the end. Also, the code is cleaner, and we have what currently seems the best solution in place. The result is there, that's what counts.
New patch will be sent in shortly.