Re: [coreboot] [PATCH 1/4] libpayload: Some more POSIX compatibility

[Stefan Reinauer]

On 11.02.2011, at 01:36, Patrick Georgi  wrote:
> Add assert.h
> Add arpa/inet.h
> Add assert-macro
>
> Signed-off-by: Patrick Georgi

Acked-by: Stefan Reinauer
> payloads/libpayload/include/arpa/inet.h |   36 ++++++++++++++++++++++++++++
> payloads/libpayload/include/assert.h    |   39 +++++++++++++++++++++++++++++++
> 2 files changed, 75 insertions(+), 0 deletions(-)
> create mode 100644 payloads/libpayload/include/arpa/inet.h
> create mode 100644 payloads/libpayload/include/assert.h
>
> diff --git a/payloads/libpayload/include/arpa/inet.h b/payloads/libpayload/include/arpa/inet.h
> new file mode 100644
> index 0000000..4fc8a89
> --- /dev/null
> +++ b/payloads/libpayload/include/arpa/inet.h
> @@ -0,0 +1,36 @@
> +/*
> This file is part of the libpayload project.
> Copyright (C) 2011 secunet Security Networks AG
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions
> are met:
> Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
> Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the distribution.
> The name of the author may not be used to endorse or promote products
> derived from this software without specific prior written permission.
> THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> SUCH DAMAGE.
> */
>
> +#ifndef _ARPA_INET_H
> +#define _ARPA_INET_H
>
> +// arch/endian.h already provides ?to?[lwb]
> +#include <arch/endian.h>
>
> +#endif
> diff --git a/payloads/libpayload/include/assert.h b/payloads/libpayload/include/assert.h
> new file mode 100644
> index 0000000..fda4bc0
> --- /dev/null
> +++ b/payloads/libpayload/include/assert.h
> @@ -0,0 +1,39 @@
> +/*
> This file is part of the libpayload project.
> Copyright (C) 2011 secunet Security Networks AG
> Redistribution and use in source and binary forms, with or without
> modification, are permitted provided that the following conditions
> are met:
> Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
> Redistributions in binary form must reproduce the above copyright
> notice, this list of conditions and the following disclaimer in the
> documentation and/or other materials provided with the distribution.
> The name of the author may not be used to endorse or promote products
> derived from this software without specific prior written permission.
> THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> SUCH DAMAGE.
> */
>
> +#include <stdlib.h>
>
> +// assert's existence depends on NDEBUG state on _last_ inclusion of assert.h,
> +// so don't guard this against double-includes.
> +#ifdef NDEBUG
> +// Heisenbugs appear if statement has side-effects. This could be worked around but does the standard allow for that?
> +#define assert(statement)
> +#else
> +#define assert(statement) if ((statement) == 0) { printf("assertion failed in file %s, function %s(), line %s\n", __FILE__, __FUNCTION__, __LINE__); abort(); }
> +#endif
>
> 1.7.1