[coreboot] NULL pointer deref in soc/intel/skylake/irq.c

[Benjamin Doron]

Hi all,
`src/soc/intel/skylake/irq.c:soc_irq_settings()` dereferences NULL by memcpy'ing devintconfig to params->DevIntConfigPtr. As far as I can tell, this happens because we're copying a structure onto a UPD that's actually just the pointer, rather than assigning the UPD to the buffer.

devintconfig is static, so will `params->DevIntConfigPtr = devintconfig` work? It would point inside the data section, as I understand. Alternatively, calling `malloc()` first should work.

I'm away from my computer now, so I can't test these alternatives yet.

Best regards,
Benjamin