On Thu, Jul 31, 2014 at 12:00 PM, Kyösti Mälkki kyosti.malkki@gmail.com wrote:
I see some of you first patches had a couple commits from Chromium tree squashed into one. Why was the approach changed from how eg. Aaron and Stefan handled the process?
For the ARM platforms, there were a lot of files that were imported from other projects and were unnecessary and/or inconsistent with coreboot style. I suspect that squashing many of those commits helps to make it build cleanly against upstream without polluting the codebase with a lot of obsolete/unwanted stuff that got cleaned out anyway.
git log --oneline no longer serves as a datapoint in attempt to compare which changes from Chromium branches have been upstreamed or not.
Perhaps, and hopefully the x86 stuff won't need as much squashing since there should be less churn in that part of the codebase.
IMHO the most important reason to do this at all is to provide a good starting point to people who are interested in developing future products, not necessarily to bring in 100% of the patches from chromium for past products. Even if we miss a few patches or some history is lost -- and I obviously hope we don't lose anything important -- that's a small price to pay to make "upstream first" development easier for new products.
Did you develop some nice method to keep track of which branches from Chromium we can consider as completely upstreamed?
Do you have the facilities to do regular board-status script runs for recent Chromebooks?
Kyösti
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot