Re: [coreboot] [PATCH] Kconfig HT

[mylesgw]

On Thu, Sep 24, 2009 at 8:32 AM, Patrick Georgi wrote:
> would adding "select HYPERTRANSPORT_PLUGIN_SUPPORT" to all HT aware
> northbridges work for you?

It did after I switched the order of the Kconfig files in src/Kconfig.  If
devices came before northbridge I couldn't get it to work.
> +ifdef CONFIG_HT_CHAIN_UNITID_BASE
>   obj-y += hypertransport.o
>
> +endif
>
> maybe replace that with
> obj-$(CONFIG_HT_CHAIN_UNITID_BASE) += hypertransport.o?
> or rather use HYPERTRANSPORT_PLUGIN_SUPPORT, once it's defined, but the
> pattern still applies..?

Yes.  I couldn't do it with HT_CHAIN_UNITID_BASE since it wasn't boolean.
> > Signed-off-by: Myles Watson
>
> Acked-by: Patrick Georgi

Rev. 4670.

Thanks,
Myles