Re: [coreboot] [PATCH] v3: fix Kconfig dependencies, update defconfigs

[Carl-Daniel Hailfinger]

On 18.08.2008 17:43, ron minnich wrote:
> On Mon, Aug 18, 2008 at 5:08 AM, Carl-Daniel Hailfinger
>  wrote:
> > Fix Kconfig dependencies and update defconfigs.
> >
> > A few questions remain:
> > Should CONFIG_SMP be selectable on GeodeLX and Qemu? Might make sense
> >
> > for debugging.
>
> only if you can make some test in hardware so that you know you are
> not SMP. Otherwise, how can the AP scan other CPUs and find out there
> are not any?

It seems the K8 code is using CONFIG_LOGICAL_CPUS for that.

CONFIG_SMP does only control spinlocks and enables the LAPIC
unconditionally.
> > Should CONFIG_IOAPIC be selectable on GeodeLX and Qemu? Maybe for Qemu.
>
> not sure on LX but it is unlikely?

Jordan says the LX doesn't support it.
> > Should CONFIG_USBDEBUG_DIRECT be selectable on GeodeLX and Qemu? I
> >
> > don't think so.
>
> not sure. Does hardware support it?

The Geode CS5536 companion doesn't.

Updated patch checked in.

Regards,
Carl-Daniel