On Fri, May 02, 2008 at 06:34:34PM +0200, Carl-Daniel Hailfinger wrote:
Two minor comments:
- People should have a separate address to turn to for any flashrom
success reports. Subscribing to a list just for that purpose is user-hostile.
Changed to flashrom@coreboot.org now. How we handle that adress I don't know.
- We need separate test status for probe/read/erase/verify.
Good idea. I've changed the patch.
If the issues above are addressed, the patch is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks! I'll hold off committing the attached patch for one more round of comments though.
On Fri, May 02, 2008 at 01:23:52PM -0400, Joe wrote:
Why not just put a link in the manpage pointing to http://www.coreboot.org/Flashrom#Supported_devices to show which chips have been tested?
A good idea, but unfortunately the wiki does not know what version of the program the user is running. If the user has an old version, bugs may have been fixed since the release to make more chips work, which is what the wiki would say, but they will still not work in the user's version. :\
//Peter