Re: [coreboot] [PATCH 3/3] X60: use I/O 0x1600/0x1604 for ACPI accesses

[Stefan Reinauer]

* Sven Schnelle  [110312 01:18]:
> Signed-off-by: Sven Schnelle
>
> src/mainboard/lenovo/x60/mainboard.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
> index b8e6a49..79e4a83 100644
> --- a/src/mainboard/lenovo/x60/mainboard.c
> +++ b/src/mainboard/lenovo/x60/mainboard.c
> @@ -50,6 +50,11 @@ static void wlan_enable(void)
>
> static void mainboard_enable(device_t dev)
>  {
> /* Enable 1600/1604 register pair */
> ec_set_bit(0x00, 0x05);
> /* switch to just enabled registers for ACPI */

I think the comment is misleading. ACPI has nothing to do with this.
> ec_set_ports(0x1604, 0x1600);