Am Donnerstag, den 27.11.2008, 17:18 +0100 schrieb Carl-Daniel Hailfinger:
It would be great if you could split the regular expression bugfix from the rest of the patch. That makes reviewing a lot easier and the individual patches are smaller.
The perl regexp change is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Besides this, there are only two more parts: 1. add more flags to compilation of all mainboards (debug symbols, line numbers, verbose assembly) 2. create .disasm files of crto and coreboot, containing the disassembly (in src/config/Config.lb)
I did a full abuild run with the debug symbols on, using a payload that leaves barely enough space for coreboot without these changes in most ROMs (4kb or so more, and many of the boards failed). All boards built just the same with debug symbols, so increase in size (if any) should be acceptable.
The only drawback was that the tree was much larger, as the non-stripped coreboot binary was 2-3 times the size, the disassembly of all coreboot images takes some space, ...
I first thought about splitting the regex off, too - but seriously, the other stuff is just as repetitive (same file, even), and imho functionally trivial (but potentially a large impact, thus the tests)
Regards, Patrick Georgi