Re: [coreboot] [PATCH] flashrom: Improve coreboot image detection heuristic

[Peter Stuge]

On Fri, Jul 04, 2008 at 06:11:54PM +0200, Carl-Daniel Hailfinger wrote:
> (!isprint(*(const char *)(bios + size - *(walk - 1))) &&
> (*(const char *)(bios + size - *(walk - 1)))) ||
> (!isprint(*(const char *)(bios + size - *(walk - 2))) &&
> (*(const char *)(bios + size - *(walk - 2))))) {

NAK. I would like to fix this in a better way, or not at all. A four
line long condition can simply not be the best way, even in the short
term.

//Peter