Re: [coreboot] v2[PATCH]RCA RM4100 i82830 support

> > > 	if ((sz.side2 != 0) && (sz.side1 != sz.side2)) {
> > > 		print_err("This board only supports\r\n");
> > > 		print_err("symmetrical dual-sided DIMMs\r\n");
> > > 		die("HALT\r\n");
> > > 	}
> >
> > This should be moved right into the detection routine. If the
> > northbridge can't handle it, then just die if sz.side1 |= sz.side2.
> > The other option is to set sz.side2 to 0, and try to use it like a
> > single-sided dimm.

ok how about this. Below is saying that IF THERE IS A SECOND SIDE and  
it does not equal the first side than give a message, use as a single  
sided dimm, and move on.

/* The i82830 only supports a symmetrical dual-sided dimm
    		 * and can't handle DIMMs smaller than 32MB per
    		 * side or larger than 256MB per side.
    		 */
    		if ((sz.side2 != 0) && (sz.side1 != sz.side2)) {
    			print_err("This northbridge only supports\r\n");
    			print_err("symmetrical dual-sided DIMMs\r\n");
    			print_err("booting as a single-sided DIMM\r\n");
    			sz.side2 = 0;
    		}
    		if ((sz.side1 < 32)) {
    			print_err("DIMMs smaller than 32MB per side\r\n");
    			print_err("are not supported on this northbridge\r\n");
    			die("HALT\r\n");
    		}

if ((sz.side1 > 256)) {
    			print_err("DIMMs larger than 256MB per side\r\n");
    			print_err("are not supported on this northbridge\r\n");
    			die("HALT\r\n");
    		}

Thanks - Joe