Re: [LinuxBIOS] [PATCH] improved SPI flash support (restructured)

[Carl-Daniel Hailfinger]

On 29.09.2007 15:59, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger  [070929 04:08]:
> > +#define ITE_SUPERIO_PORT1	0x2e
> > +#define ITE_SUPERIO_PORT2	0x4e
>
> This has nothing to do with the IDE. All PC SuperIOs are on 2e or 4e.
> > +int probe_spi(struct flashchip *flash)
> > +{
> > unsigned char readarr[3];
>
> This should be a struct imho
>
> typedef struct spi_id {
>         unsigned char vendor_id;
>         unsigned short device_id;
> } spi_id_t;

Yes, but the underlying generic SPI function uses an array for commands
and results. Once I add write/erase support, it will become obvious why
I used unsigned char arrays.
> The driver does only probe so far, right?

Yes.
> what about the other SPI commands?

Will be implemented once this patch has been tested.

Carl-Daniel