13 May
2008
13 May
'08
11:23 p.m.
Hi Carl-Daniel,
my colleague Dominik will investigate into this; we will provide a new patch within the next few days.
--
Mit freundlichen Grüßen / Best regards
Claus Gindhart
SW R&D
Kontron Modular Computers
phone :++49 (0)8341-803-374
mailto:claus.gindhart@kontron.com
http://www.kontron.com
On Tuesday 13 May 2008, Carl-Daniel Hailfinger wrote:
> On 13.05.2008 17:37, Stefan Reinauer wrote:
> > Carl-Daniel Hailfinger wrote:
> >> Hi Claus,
> >>
> >> thanks for your patch. I will work on it and try to integrate it more
> >> with the existing flashrom structure.
> >>
> >> On 13.05.2008 15:29, Claus Gindhart wrote:
> >>> This patch adds support for the SPI Chips Atmel AT25DF32,
> >>> ST M25P80, ST M25P16, M25P32, ST M25P64 attached to the ICH9.
> >>> Because chipset plays an important role in communicating with these
> >>> chips, it was not possible to integrate this support into the already
> >>> existing spi.c
> >>> This module was tested with the devices as mentioned above, but
> >>> it should be easy to expand it for other SPI chips attached to an ICH.
> >>>
> >>> Signed-off-by: Claus Gindhart claus.gindhart@kontron.com
> >>
> >> Expect some feedback and a patch against your tree to improve
> >> integration tomorrow.
> >
> > I suggest we check this in and you work on the public tree. There is no
> > reason to delay check-in.
>
> Sorry, the patch Claus posted duplicates a lot of existing
> infrastructure because the existing SPI abstraction was not clearly
> visible. That means to support a SPI flash chip with ICH9 and any other
> chipset we have to add it twice to flashchips.c. I have posted 3 patches
> to improve the existing SPI abstraction and 2 of them have already been
> merged. Once the third patch is merged, I can eliminate all reasons for
> duplicate listings in flashcips.c with a fourth patch. I expect to have
> all patches merged tomorrow and then we can rework Claus' patch a bit more.
>
> Claus, if I don't find time until tomorrow to post a patch against your
> tree, can you look into using spi.h for some of your #defines? I'm
>
> thinking of these:
> > +#define SPI_ST_M25P_COMMAND_WRITE 0x02
> > +#define SPI_ST_M25P_COMMAND_READ 0x03
> > +#define SPI_ST_M25P_COMMAND_ERASE 0xd8
> > +#define SPI_ST_M25P_COMMAND_WRITE_DISABLE 0x04
> > +#define SPI_ST_M25P_COMMAND_READ_STATUS 0x05
> > +#define SPI_ST_M25P_COMMAND_WRITE_ENABLE 0x06
> > +#define SPI_ST_M25P_COMMAND_JDEC 0x9F
> > +#define SPI_ST_M25P_COMMAND_RES_PD 0xab
> > +#define SPI_ST_M25P_COMMAND_WRITE_S_EN 0x50
> > +#define SPI_ST_M25P_COMMAND_WRITE_S 0x01
> > +#define SPI_ST_M25P_COMMAND_BULK_ERASE 0xc7
>
> AFAICS all of them are in spi.h under a different name and it would be
> cool if you could reuse the definitions from spi.h
>
> Regards,
> Carl-Daniel
Kontron Modular Computers GmbH
Geschaeftsfuehrer / Managing Directors: Ulrich Gehrmann, Thomas Sabisch
Sitz der Gesellschaft / Registered Office: Kaufbeuren, Rechtsform / Legal: GmbH
Amtsgericht / Local District Court Kempten, HRB Nr. / Trade Register No. 6195
The information contained in this document is CONFIDENTIAL and property of Kontron.
Any unauthorized review, use, disclosure or distribution is prohibited without express
written consent of Kontron. If you are not the intended recipient, please contact the
sender and destroy all copies of the original message and enclosed attachments.
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen und ist
Eigentum von Kontron. Die Verwendung und Weitergabe von jeglichen Inhalten ist
ohne ausdrückliche schriftliche Genehmigung von Kontron strikt untersagt. Wenn Sie
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten diese Mail und enthaltene Dokumente.