Re: [LinuxBIOS] [PATCH] v3: Kconfig payload options and README improvements

[Uwe Hermann]

On Thu, May 31, 2007 at 01:43:43AM +0200, Stefan Reinauer wrote:
> > Index: Makefile
> >
> > --- Makefile	(Revision 338)
> > +++ Makefile	(Arbeitskopie)
> >  doxygen:
> >    $(Q)$(DOXYGEN) util/doxygen/Doxyfile.LinuxBIOS
> >
> > +payload:
> > $(Q)printf "Not yet implemented. This will invoke a helper tool.\n"
>
> I'd wait checking this stuff in until we really do something here.

OK, it's commented now.
> > $(Q)cp $(CONFIG_PAYLOAD) $(obj)/lar.tmp/normal/payload
> > $(Q)# TODO: Copy no payload or empty payload if CONFIG_PAYLOAD_NONE.
> > $(Q)cp $(CONFIG_PAYLOAD_FILE) $(obj)/lar.tmp/normal/payload
>
> maybe something like 
> if [ -r $(CONFIG_PAYLOAD_FILE) ]; then cp .... ; fi

Yep, done.
> > -STAGE2_LIB_OBJ       = stage2.o clog2.o mem.o malloc.o tables.o delay.o compute_ip_checksum.o
> > +STAGE2_LIB_OBJ       = stage2.o clog2.o mem.o malloc.o tables.o delay.o \
> >        compute_ip_checksum.o
>
> Uh oh, lots of unrelated whitespace stuff in this patch.

True, it's gone now. I made an extra commit out of that.

Updated patch attached.

Uwe.