Re: [coreboot] [PATCH] v3: various fixes to the device code

[ron minnich]

On Wed, Apr 16, 2008 at 9:21 AM, Carl-Daniel Hailfinger
 wrote:
> Index: LinuxBIOSv3-stuff/device/hypertransport.c

I *think* AGESA will take over this function, this file may be able to
be dropped.
> ===================================================================
>  --- LinuxBIOSv3-stuff/device/hypertransport.c   (Revision 658)
>  +++ LinuxBIOSv3-stuff/device/hypertransport.c   (Arbeitskopie)
>  @@ -580,10 +580,11 @@
>          */
>         if (old_devices) {
>                 struct device *left;
>           printk(BIOS_ERR, "HT: Left over static devices:\n");
>          for (left = old_devices; left; left = left->sibling) {
>                   printk(BIOS_DEBUG, "%s\n", dev_path(left));
>                   printk(BIOS_ERR, "%s\n", dev_path(left));
>          }
>           printk(BIOS_ERR, "HT: Left over static devices.\n");
>           printk(BIOS_ERR, "HT: End of leftover list.\n");
>          /* Put back the left over static device, and let
>           * pci_scan_bus() disable it.
>           */
> Index: LinuxBIOSv3-stuff/device/pci_device.c
>
> --- LinuxBIOSv3-stuff/device/pci_device.c       (Revision 658)
>  +++ LinuxBIOSv3-stuff/device/pci_device.c       (Arbeitskopie)
>  @@ -883,7 +883,7 @@
>         dev = 0;
>         printk(BIOS_SPEW, "%s: list is %p, *list is %p\n", __func__, list,
>                *list);
>   for (/* */; *list; list = &(*list)->sibling) {
>   for (; *list; list = &(*list)->sibling) {
>          printk(BIOS_SPEW, "%s: check dev %s \n", __func__,
>                 (*list)->dtsname);
>          if ((*list)->path.type != DEVICE_PATH_PCI) {
>
> @@ -1122,10 +1122,11 @@
>          */
>         if (old_devices) {
>                 struct device *left;
>           printk(BIOS_ERR, "PCI: Left over static devices:\n");

no, leave it at spew. It's not an error. These are leftover *PCI* devices,
and that doesn't matter if they are, e.g., a superio.
>             for (left = old_devices; left; left = left->sibling) {
>                   printk(BIOS_SPEW, "%s\n", left->dtsname);
>                   printk(BIOS_ERR, "%s\n", left->dtsname);=

same here. Needs to be spew, not ERR.

ron