Re: [coreboot] [commit] r5319 - trunk/src/arch/i386/include/arch

[Myles Watson]

On Mon, Mar 29, 2010 at 4:05 PM, repository service wrote:
> Author: stepan
> Date: Tue Mar 30 00:05:26 2010
> New Revision: 5319
> URL: https://tracker.coreboot.org/trac/coreboot/changeset/5319
>
> Log:
> drop GCC 2.x workaround, GCC 2.x is not supported anymore.
> warn if we didn't specify IRQ_SLOT_COUNT in Kconfig
>
> Signed-off-by: Stefan Reinauer 
> Acked-by: Stefan Reinauer
>
> Modified:
>   trunk/src/arch/i386/include/arch/pirq_routing.h
>
> Modified: trunk/src/arch/i386/include/arch/pirq_routing.h
>
> ==============================================================================
> --- trunk/src/arch/i386/include/arch/pirq_routing.h     Mon Mar 29 23:56:26
> 2010        (r5318)
> +++ trunk/src/arch/i386/include/arch/pirq_routing.h     Tue Mar 30 00:05:26
> 2010        (r5319)
> @@ -18,9 +18,8 @@
>
> #if defined(CONFIG_IRQ_SLOT_COUNT)
>  #define IRQ_SLOTS_COUNT CONFIG_IRQ_SLOT_COUNT
> -#elif (__GNUC__ < 3)
> -#define IRQ_SLOTS_COUNT 1
>  #else
> +#warning "No IRQ_SLOT_COUNT in Kconfig."
>  #define IRQ_SLOTS_COUNT
>  #endif
>
> I think we should get rid of IRQ_SLOTS_COUNT and move the error into

Kconfig.  The added warning is very similar to one in pirq_routing.c

Thanks,
Myles