Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2

[Bao, Zheng]

I am trying to port the ddr3 feature. I will submit a full patch to
replace this one.

Zheng

-----Original Message-----
From: Ward Vandewege [mailto:[e-mail]] 
Sent: Tuesday, July 21, 2009 3:58 AM
To: Bao, Zheng
Cc: Coreboot
Subject: Re: [coreboot] [patch] [AMD Fam10] Fix confused RB-C2 and DA-C2

On Thu, Jul 16, 2009 at 03:40:49PM +0800, Bao, Zheng wrote:
> This patch is about the DA-C2 and RB-C2. Chip with install processor
> Revision ID of 0x100F62 is DA-C2, instead of RB-C2 which was

incorrectly
> defined in raminit_amdmct.c. RB-C2's ID is 0x100F42. The Erratas

applied
> to
> them are almost the same.
>
> Issues:
> I really dont know what their nicknames are (Shanghai C2 or
>
> something).
> 2. About the mc_patch_01000086.h, I dont know if it is allowed to be
> released.
>    If you really need it, please contact AMD Inc to see if it is

public.
> I haven't made coreboot go thoroughly on this RB-C2. This patch is
>
> just half tested.
>    I am not confident it is 100% correct.
>
> Zheng
>
> Signed-off-by: Zheng Bao

With this patch, I can still boot my system with 00100F42h (RB-C2) CPUs
-
Opteron 2372HE.

Acked-by: Ward Vandewege

Thanks,
Ward.