Re: [coreboot] [PATCH] flashrom: Add support for SPI-Chips on ICH9

[Carl-Daniel Hailfinger]

Hi Dominik,

On 16.05.2008 11:45, Dominik Geyer wrote:
> Add support for SPI-Chips on ICH9. This is done by using the generic SPI 
> interface.
>
> Signed-off-by: Dominik Geyer <dominik.geyer <at> kontron.com>

This is really Great Stuff (TM)!
Acked-by: Carl-Daniel Hailfinger
> Hi Carl-Daniel,
>
> this is the rework of the initial patch. It is based on r3321 and was tested 
> with an "Atmel 25DF321" and a "ST M25P32".
>
> All points you noted were fixed. The ich_spi_command acts as a wrapper 
> function for converting arguments from spi_command to run_opcodes.

Thanks! I have looked at the structure and implementation details of
your code and it is definitely ready for merging. There are a few things
(mostly cosmetic, like outdated comments) I'd like to be fixed, but they
are not showstoppers.

Committed in r3325 (with minor rearrangements inside flash.h) and r3326
(flashchips.c update).

Regards,
Carl-Daniel