On Sun, Apr 29, 2007 at 11:36:51AM +0100, Ben Hewson wrote:
=================================================================== --- /home/ben/sw/LinuxBIOSv2/src/southbridge/via/vt8231/vt8231_ide.c (revision 2621) +++ /home/ben/sw/LinuxBIOSv2/src/southbridge/via/vt8231/vt8231_ide.c (working copy) @@ -15,6 +15,12 @@ // Run the IDE controller in 'compatiblity mode - i.e. don't use PCI // interrupts. Using PCI ints confuses linux for some reason.
/* Setting reg 0x42 here does not work. It is set in mainboard/auto.c* It probably can only be changed while the IDE is disabled* or it is possibly a timing issue. Ben Hewson29 Apr 2007.*//*@@ -22,6 +28,8 @@ pci_write_config8(dev, 0x42, enables); enables = pci_read_config8(dev, 0x42); printk_debug("enables in reg 0x42 read back as 0x%x\n", enables);
*/
Hm, I don't know about this, this file is used with densitron/dpx114 also and it should also have this fixup in auto.c.
Ben, is there really no way to have that register setting in the 8231 code in v2?
If not, then OK, we will have to document properly though. Also, in that case please just remove the code from the 8231 code rather than commenting it out. (But leave your new comment.)
//Peter