Re: [coreboot] patch: fix USB ports on DBE62, and other cs5536-based platforms

[Marc Jones]

ron minnich wrote:
> This change adds some debug prints, and a comment warning to dts on cs5536.
>
> Most importantly it fixes a simple programming error which made it so most of
> the sets on the USB were not doing anything. The bug is also in V2.
> /* the /sizeof(u32) is to convert byte offsets into u32 offsets */
> #define HCCPARAMS		(0x08/sizeof(u32))

I don't understand this change. This is standard MMIO. The memory mapped 
registers are defined 0h, 04h, 08h, 0Ah...

You could
*(bar + 08h) |= 1 << 9;
or
*(bar + 09h) |= 1 << 1;

Can you please explain?

Marc