Re: [coreboot] [patch] Cleanups in Makefile for flashrom and superiotool

[Peter Lemenkov]

Hello All!

2008/5/18 Carl-Daniel Hailfinger :
> I can understand setting PREFIX, but the reason why you need to redefine
> CFLAGS is a mystery to me.

We use our custom CFLAGS.

-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables

See here:

http://buildsys.fedoraproject.org/logs/fedora-5-epel/39019-flashrom-0-0.9.20...
> Sorry, parts of both Makefile patches are obviously wrong and even
> actively harmful

What parts?
> Will the modified install section work with a non-FSF install program as
> well, i.e. is it truly cross-platform?

No idea.